Should fixup! commits be valid?

[johnallen3d]

I'm just diving into (and falling in love with) the world of conventional commits! I've implemented this action and was surprised when it didn't fail after a particular push. I'm in the habit of making small "fixup" commits after opening a PR to clean up anything noticed in the review. I expected those to cause commitlint to fail with the idea that I'd do an interactive rebase when ready for re-review/merge. However, I noticed that the commitlint action passed when I pushed a fixup commit.

Here's my action configuration:

name: Lint Commit Messages

on:
  push:
    branches:
    - master
  pull_request:
    branches:
    - master

jobs:
  commitlint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
        with:
          fetch-depth: 0
      - uses: wagoid/commitlint-github-action@v4

[johnallen3d]

Pardon the noise, I've found that fixup is ignored by default by commitlint. I'll investigate how to change that behaviour. Thanks for the great action!