Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: database backed peerstore is deprecated #852

Closed
richard-ramos opened this issue Oct 31, 2023 · 1 comment
Closed

chore: database backed peerstore is deprecated #852

richard-ramos opened this issue Oct 31, 2023 · 1 comment

Comments

@richard-ramos
Copy link
Member

Background

Remove code related to persisting peers https://github.com/waku-org/go-waku/blob/master/cmd/waku/node.go#L219-L235
If/when the peerstore is modified to use a custom implementation in go-waku, we can then consider adding back peer persistance.

SA1019: "github.com/libp2p/go-libp2p/p2p/host/peerstore/pstoreds" is deprecated: The database-backed peerstore will be removed from go-libp2p in the future. Use the memory peerstore (pstoremem) instead. For more details see https://github.com/libp2p/go-libp2p/issues/2329 and https://github.com/libp2p/go-libp2p/issues/2355.
@fryorcraken fryorcraken added this to Waku Oct 31, 2023
@chair28980 chair28980 moved this to To Do in Waku Dec 5, 2023
@chair28980
Copy link
Contributor

Closing per go-waku pm call 2024-01-02.

@github-project-automation github-project-automation bot moved this from To Do to Done in Waku Jan 2, 2024
@chaitanyaprem chaitanyaprem mentioned this issue Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richard-ramos @chair28980