Added server errors to be displayed in the chat area #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @Oliver-I |
germanattanasio
suggested changes
Jan 17, 2019
package.json
Outdated
| @@ -28,6 +28,10 @@ | |||
| "registry": "https://registry.npmjs.org/", | |||
| "access": "public" | |||
| }, | |||
| "engines": { | |||
| "node": "6.14.4" | |||
There was a problem hiding this comment.
I read that this is to fix a 502 error but can you try with node 8.15.0? do you have a link to where the error was documented?
There was a problem hiding this comment.
Have made the changes you requested. No do not have the link, just read in one of the issues
* Show server error such as session timeout in chat window * Enforced node >=8.15.0 to resolve 502 errors with node 6.15.0 * Added 1 second pause before scrolling chat window to fix image loading in chat window
stevenpkg
force-pushed
the
error-handling
branch
from
e222a72 to
d75ecc3
Compare
germanattanasio
approved these changes
Jan 17, 2019
|
🎉 This PR is included in version 1.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show server error such as session timeout in chat window
Enforced node >=8.15.0 to resolve 502 errors with node 6.15.0
Added 1 second pause before scrolling chat window to fix image loading in chat window