Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nlc): add a deprecation message #1185

Merged
merged 4 commits into from
Sep 1, 2021
Merged

fix(nlc): add a deprecation message #1185

merged 4 commits into from
Sep 1, 2021

Conversation

nan2iz
Copy link
Contributor

@nan2iz nan2iz commented Aug 17, 2021

Summary

Add a deprecation message

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2021

CLA assistant check
All committers have signed the CLA.

@nan2iz nan2iz requested a review from jeff-arn August 17, 2021 19:32
Copy link
Contributor

@kevinkowa kevinkowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should also add something along the lines of

/**
 * @deprecated On 1 December 2021, Personality Insights will no longer be available.
 * Consider migrating to Watson Natural Language Understanding.
 * For more information, see Personality Insights Deprecation
 * (https://github.com/watson-developer-cloud/java-sdk/tree/master#personality-insights-deprecation).
 */
@Deprecated
public class PersonalityInsights extends BaseService {

This is what happens on personality insights, we just need to override the message

@nan2iz
Copy link
Contributor Author

nan2iz commented Aug 17, 2021

Looks good. We should also add something along the lines of

/**
 * @deprecated On 1 December 2021, Personality Insights will no longer be available.
 * Consider migrating to Watson Natural Language Understanding.
 * For more information, see Personality Insights Deprecation
 * (https://github.com/watson-developer-cloud/java-sdk/tree/master#personality-insights-deprecation).
 */
@Deprecated
public class PersonalityInsights extends BaseService {

This is what happens on personality insights, we just need to override the message

Thank you! I will update it.

Copy link
Contributor

@kevinkowa kevinkowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mikemosca Mikemosca merged commit b460cdd into master Sep 1, 2021
@Mikemosca Mikemosca deleted the nlc-deprecation branch September 1, 2021 11:17
watson-github-bot pushed a commit that referenced this pull request Sep 1, 2021
## [9.2.2](v9.2.1...v9.2.2) (2021-09-01)

### Bug Fixes

* **nlc:** add a deprecation message ([#1185](#1185)) ([b460cdd](b460cdd))
@watson-github-bot
Copy link
Member

🎉 This PR is included in version 9.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants