-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nlc): add a deprecation message #1185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We should also add something along the lines of
/**
* @deprecated On 1 December 2021, Personality Insights will no longer be available.
* Consider migrating to Watson Natural Language Understanding.
* For more information, see Personality Insights Deprecation
* (https://github.com/watson-developer-cloud/java-sdk/tree/master#personality-insights-deprecation).
*/
@Deprecated
public class PersonalityInsights extends BaseService {
This is what happens on personality insights, we just need to override the message
Thank you! I will update it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## [9.2.2](v9.2.1...v9.2.2) (2021-09-01) ### Bug Fixes * **nlc:** add a deprecation message ([#1185](#1185)) ([b460cdd](b460cdd))
🎉 This PR is included in version 9.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Add a deprecation message