Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid use of BasicClientConnManager: connection still allocated #8

Closed
germanattanasio opened this issue Jul 8, 2015 · 3 comments
Closed
Assignees

Comments

@germanattanasio
Copy link
Contributor

Currently the execute() method is single thread and try to use only one HTTP connection. This is a big problem if the wrapper is being used in a multi-thread environment so we need to add a http connection pool.

See:

@germanattanasio
Copy link
Contributor Author

I'm going to fully read the InputStream and that should be enough to close the http connection. I may also include a connection manager to also handle a pool of http connections.

I'm currently looking at: http://grepcode.com/file/repo1.maven.org/maven2/org.apache.httpcomponents/httpcore/4.0.1/org/apache/http/util/EntityUtils.java

germanattanasio added a commit that referenced this issue Jul 21, 2015
@germanattanasio
Copy link
Contributor Author

More work on 5f4420e

@aarora91
Copy link

Thanks. Just tested this with the update. Works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants