Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Void elements reviewer #51

Open
paganotoni opened this issue Aug 4, 2020 · 2 comments
Open

Void elements reviewer #51

paganotoni opened this issue Aug 4, 2020 · 2 comments
Assignees
Labels
Proposal Proposal of features/changes to implement in Milo.

Comments

@paganotoni
Copy link
Member

paganotoni commented Aug 4, 2020

As we're focusing on HTML syntax for HTML we could add a reviewer that checks for non-void self-closing tags. In the HTML syntax for HTML there are a set of these elements that should be self closed:

  • area
  • base
  • br
  • col
  • command
  • embed
  • hr
  • img
  • input
  • keygen
  • link
  • meta
  • param
  • source
  • track
  • wbr

We should check that these elements never have content. And also check that only these elements are self-closed. (These may be two linters).

@paganotoni paganotoni added the Proposal Proposal of features/changes to implement in Milo. label Aug 21, 2020
@paganotoni
Copy link
Member Author

cc @larrymjordan @tatang26

@paganotoni paganotoni self-assigned this Sep 6, 2020
@paganotoni paganotoni changed the title Proposal: Void elements reviewer Void elements reviewer Sep 8, 2020
@paganotoni
Copy link
Member Author

There is another reviewer we could add here which is related with adding the self-close slash on void tags, I think this is more related with style preferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal Proposal of features/changes to implement in Milo.
Projects
None yet
Development

No branches or pull requests

1 participant