Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change should have been a major version update #78

Closed
GeoffreyEmerson opened this issue Apr 11, 2023 · 0 comments · Fixed by #79
Closed

Breaking change should have been a major version update #78

GeoffreyEmerson opened this issue Apr 11, 2023 · 0 comments · Fixed by #79

Comments

@GeoffreyEmerson
Copy link

Firstly, thank you for your work! 🏆

tl;dr - Version 1.3.0 should have been a major bump to 2.0.0.

What I recently learned: Semver has this annoying aspect where the "magic zero" packages can have breaking changes in the "minor" updates. This is accounted for in the use of the carat, where packagers won't download v0.17.0 if you specify "^0.16.0". But using the carat on a package that has a major version greater than 0 will allow packagers to download increased minor versions.

The issue: esbuild-plugin-pino does not use the Zero major version, so those of us using the carat specifier will get v1.3.0 downloaded when we refresh our packages, which does not correspond to esbuild versions below 0.17.0.

Even though esbuild-plugin-pino v1.3.0 is only adapting to a minor version update in another package, that adaptation was a breaking change, and so the version bump should have been a major version update to 2.0.0.

Suggestion: Consider deleting 1.3.0 from the registry and resubmitting it as 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant