Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new tokenizer column offset to fix fstring ast locations #195

Conversation

lysnikolaou
Copy link

Use the changes from python#97984 and python#98000 to product correct ast locations for fstrings.

@lysnikolaou lysnikolaou requested a review from pablogsal as a code owner October 7, 2022 23:47
@pablogsal pablogsal merged commit 09e7732 into fstring-grammar-rebased-after-sprint Oct 8, 2022
@pablogsal pablogsal deleted the fstring-ast-numbers-after-sprint branch October 8, 2022 23:20
@pablogsal
Copy link

Great work 🎉

We are closer ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants