fix: if flat or percentage commission is set, remove the required field

getdokan · Nov 11, 2019 · a3170cc · a3170cc
1 parent 5abdeb2
commit a3170cc
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/src/admin/pages/Settings.vue b/src/admin/pages/Settings.vue
@@ -249,6 +249,11 @@
                         if ( field in value && value[field].length < 1 ) {
                             if ( ! this.errors.includes( field ) ) {
                                 this.errors.push( field );
+
+                                // If flat or percentage commission is set. Remove the required field.
+                                if ( 'flat' === value['commission_type'] || 'percentage' === value['commission_type'] ) {
+                                    this.errors = this.arrayRemove( this.errors, 'admin_percentage' );
+                                }
                             }
                         }
                     } );
@@ -259,6 +264,12 @@
                 }
 
                 return false;
+            },
+
+            arrayRemove( array, value ) {
+               return array.filter( ( element ) => {
+                   return element !== value;
+               });
             }
         },