fix: show notice if product SKU is not unique while updating product (#…

…602)
getdokan · Apr 17, 2019 · ff7b23e · ff7b23e
1 parent 307c329
commit ff7b23e
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 9 deletions.
diff --git a/classes/template-products.php b/classes/template-products.php
@@ -450,8 +450,17 @@ public function handle_product_update() {
 
             do_action( 'dokan_product_updated', $post_id, $postdata );
 
+
             $redirect = apply_filters( 'dokan_add_new_product_redirect', dokan_edit_product_url( $post_id ), $post_id );
 
+            // if any error inside dokan_process_product_meta function
+            global $woocommerce_errors;
+
+            if ( $woocommerce_errors ) {
+                wp_redirect( add_query_arg( array( 'errors' => array_map( 'urlencode', $woocommerce_errors ) ), $redirect ) );
+                exit;
+            }
+
             wp_redirect( add_query_arg( array( 'message' => 'success' ), $redirect ) );
             exit;
         }

diff --git a/includes/wc-functions.php b/includes/wc-functions.php
@@ -100,7 +100,7 @@ function dokan_process_product_meta( $post_id, $data = [] ) {
             $unique_sku = wc_product_has_unique_sku( $post_id, $new_sku );
 
             if ( ! $unique_sku ) {
-                $woocommerce_errors[] = ( __( 'Product SKU must be unique.', 'dokan-lite' ) );
+                $woocommerce_errors[] = __( 'Product SKU must be unique', 'dokan-lite' );
             } else {
                 update_post_meta( $post_id, '_sku', $new_sku );
             }

diff --git a/templates/products/new-product-single.php b/templates/products/new-product-single.php
@@ -56,16 +56,17 @@
 if ( ! $from_shortcode ) {
     get_header();
 }
-?>
 
-<?php
+if ( ! empty( $_GET['errors'] ) ) {
+    Dokan_Template_Products::$errors = $_GET['errors'];
+}
 
-    /**
-     *  dokan_dashboard_wrap_before hook
-     *
-     *  @since 2.4
-     */
-    do_action( 'dokan_dashboard_wrap_before', $post, $post_id );
+/**
+ *  dokan_dashboard_wrap_before hook
+ *
+ *  @since 2.4
+ */
+do_action( 'dokan_dashboard_wrap_before', $post, $post_id );
 ?>
 
 <?php do_action( 'dokan_dashboard_wrap_start' ); ?>