fix: Bug fix for "Withdrawal current balance is incorrect" #882
Conversation
|
Please merge |
|
Please merge, because we need to fix this bug immediately |
|
@ceefour Did you check Reports? It's not working properly. When caching enables our current implementation for Withdrew current balance is wrong & reports is fine. but this PR cause wrong Reports. Please look into this scenario. |
|
@zamandevs Thank you for confirming that "When caching enabled our current implementation for Withdraw current balance is wrong & reports is fine" Note that I am not a weDevs developer, I am developer with an active Dokan Professional 3 Sites license. However, previously weDevs have refused to acknowledge this problem since more than a month ago, and blamed the caching plugin. That's why I attempted, with very limited knowledge of Dokan plugin internals, to make my own fix and contribute the solution back. Can you confirm that weDevs will provide a proper fix to this problem and can you give a time estimate ? |
|
@ceefour Thanks for your contribution. hopefully, we will fix this on the next release. |
includes/Withdraw/Hooks.php
Outdated
| $cache_group = 'dokan_seller_data_' . $user_id; | ||
| $cache_key = 'dokan_seller_balance_' . $user_id; | ||
| wp_cache_delete( $cache_key, $cache_group ); | ||
| dokan_cache_update_group( $cache_key , $cache_group ); |
There was a problem hiding this comment.
@ceefour we don't need this line 35. If you remove this line, we can merge this PR.
includes/Withdraw/Hooks.php
Outdated
| @@ -28,7 +28,11 @@ public function __construct() { | |||
| * @return void | |||
| */ | |||
| public static function delete_seller_balance_cache( $status, $user_id, $id ) { | |||
| wp_cache_delete( 'dokan_seller_balance_' . $user_id ); | |||
| // Fix Dokan Pro ticket #338760: Current balance after withdrawal incorrect | |||
There was a problem hiding this comment.
Please remove the comment!
ceefour
force-pushed
the
patch-1
branch
2 times, most recently
from
c81d14c to
ae3c28c
Compare
|
@tareq1988 @kapilpaul I've removed the requested lines. Please re-review for merge. |
Reference: Dokan Pro support ticket #338760.
This PR fixes the bug that occurs because Dokan did not use proper cache behavior :