Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: Apply new filter on product listing status #950

Merged
merged 2 commits into from
Nov 12, 2020
Merged

update: Apply new filter on product listing status #950

merged 2 commits into from
Nov 12, 2020

Conversation

alamgircsebd
Copy link
Contributor

No description provided.

@alamgircsebd alamgircsebd added Needs: Dev Review It requires a developer review and approval Needs: Testing This requires further testing labels Nov 9, 2020
kapilpaul
kapilpaul reviewed Nov 9, 2020
View reviewed changes
Copy link
Contributor

@kapilpaul kapilpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit seems ok. We should use the shorthand array declaration. This is also a rule in our phpcs.

@kapilpaul kapilpaul added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Nov 9, 2020
@shanjidah shanjidah added Type: Bug and removed Needs: Testing This requires further testing labels Nov 9, 2020
@alamgircsebd alamgircsebd added Ready to Merge This PR is now ready to be merged and removed Type: Bug labels Nov 12, 2020
@tareq1988 tareq1988 merged commit 7f5b680 into getdokan:develop Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapilpaul kapilpaul kapilpaul left review comments

Assignees
No one assigned
Labels
Ready to Merge This PR is now ready to be merged 👍 Dev Review Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alamgircsebd @kapilpaul @tareq1988 @shanjidah