gql: Search with multiple target vectors and weights #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch + Extended Serializer.array to support nested arrays.
|
Great to see you again! Thanks for the contribution. |
|
I'll need to bump the version of the target container to v1.27 and update the integration tests to use the new feature before we merge. |
Updated integration test to use multiple target feature.
Previously BaseClient would "swallow" these errors, assuming HTTP 200 means a successful request. However, GraphQL specs allow it to send status 200 alongside a response body with a list of errors.
bevzzz
force-pushed
the
feature/multiple-vectors-per-target
branch
from
130ea05
to
4dfddc4
Compare
In v1.27 sending a replication request which requests more nodes than is available produces a different error message.
It seems that in v1.27 the "groupBy" property should be requested as well, otherwise the server returns fewer results than before.
This commit mirrors changes in the Go client: weaviate/weaviate-go-client@6fa31b9
WeaviateClass has a default filter strategy "sweeping"
In contrast to the previous implementation, this approach inverts the dependencies: BaseClient provides a mechanism for an external class to extract errors from "custom" locations in the response body, while staying entirely unaware of the concrete classes that might do that.
Fix invalid @returns tag in Javadoc
src/main/java/io/weaviate/client/v1/misc/model/VectorIndexConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/io/weaviate/client/v1/misc/model/ReplicationConfig.java
Outdated
Show resolved
Hide resolved
BaseClient will give GraphQLResponse special treatment
- Renamed FilterStrategy enum - Dropped default values for filtera and deletion strategy configs
src/test/java/io/weaviate/integration/client/schema/ClientSchemaTest.java
Show resolved
Hide resolved
antas-marcin
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #304
This PR adds support for "multiple vectors per target" and "multiple weights per target" features in search, using the PR from go-client as a reference.
Additionally:
BaseClientto report GraphQL errors returned in responses with status 2001.27DeletionStrategyandFilterStrategyin class configurationDetails
{ Get { Passage( hybrid: { query: "Passage content 2" alpha: 0.9 searches: { nearText: { concepts: ["Passage content 2"] } } } groupBy: { path: ["content"], groups: 3, objectsPerGroup: 10 } ) { """ A query which does not request any properties besides _additional yields 3 'hits' in v1.26. The same query only yields 1 'hit' in v1.27. Adding the groupBy-property (content) to the list of returned properties 'fixes' that behaviour. """ content _additional { ... } } } }How is this tested?
Added unit tests for
TargetsandNearVectorArgumentbuilders.