feat: add hex-alpha-color-picker web component #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyzerner
force-pushed
the
hex-alpha
branch
from
4768e4b to
d2c2a7d
Compare
web-padawan
force-pushed
the
hex-alpha
branch
from
d2c2a7d to
cb2bb9a
Compare
web-padawan
reviewed
Nov 4, 2022
There was a problem hiding this comment.
@tobyzerner Thanks for the PR! I updated it to only include hex-alpha-color-picker.
Also added some missing unit tests for new code, to keep 100% test coverage.
Let me extract your changes for hex-input component to a separate PR.
web-padawan
changed the title
<hex-alpha-color-picker> and support alpha in <hex-input>
web-padawan
approved these changes
Nov 4, 2022
This was referenced Nov 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @web-padawan, I wanted to get the ball rolling on #69. Haven't done anything with tests but the basic functionality has been ported from react-colorful. Feel free to take it from here!