Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove package lock files from packages #1169

Merged
merged 2 commits into from
Apr 4, 2022
Merged

chore: remove package lock files from packages #1169

merged 2 commits into from
Apr 4, 2022

Conversation

olizilla
Copy link
Contributor

@olizilla olizilla commented Mar 28, 2022 •
edited
Loading

only the package-lock at the root of the mono-repo is used to lock our deps. The others are imposters and are hereby deleted and gitignore'd

this PR also updates our root package-lock.json by removing the local node_modules dir and running npm i.

$ rm -rf node_modules

$ npm i
added 3138 packages, removed 4 packages, changed 6 packages, and audited 3251 packages in 1m

$ find packages -name "package-lock.json" -depth 2
packages/website/package-lock.json
packages/docs/package-lock.json
packages/db/package-lock.json
packages/api/package-lock.json
packages/client/package-lock.json

$ find packages -name "package-lock.json" -depth 2 -exec rm {} \;

olizilla added 2 commits March 28, 2022 15:06
@olizilla
chore: remove package-lock files from packages
36063f5 
the package-lock lives at the root of the mono-repo. All others are imposters, so are here deleted.

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <[email protected]>
@olizilla
chore: ignore package-lock files in the packages
e4d6d7c 
only the package-lock at the root of the mono-repo is used to lock our deps. The others are imposters and are hereby ignored.

License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans <[email protected]>
vasco-santos
vasco-santos approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@olizilla olizilla merged commit bef6e0b into main Apr 4, 2022
@olizilla olizilla deleted the remove-imposter-package-locks branch April 4, 2022 10:09
@github-actions github-actions bot mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olizilla @vasco-santos