Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typedefs for user tag functions #1387

Merged
merged 5 commits into from
Jun 14, 2022
Merged

Conversation

adamalton
Copy link
Contributor

This just tidies up the typedefs for some of the user tag related functions where were changed/added in #1322, and also improves the function signature of the createUserTag function.

@adamalton adamalton requested a review from flea89 May 31, 2022 11:03
Copy link
Contributor

@flea89 flea89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments/suggestions

packages/api/src/utils/tags.js Outdated Show resolved Hide resolved
packages/db/index.d.ts Outdated Show resolved Hide resolved
packages/db/index.d.ts Outdated Show resolved Hide resolved
packages/db/index.js Outdated Show resolved Hide resolved
@adamalton adamalton requested a review from flea89 June 13, 2022 16:43
Copy link
Contributor

@flea89 flea89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks mate.

@adamalton adamalton merged commit 6f3500c into main Jun 14, 2022
@adamalton adamalton deleted the chore/fix-typedefs branch June 14, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants