Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use car block validator #2241

Merged
merged 1 commit into from
Mar 15, 2023
Merged

fix: use car block validator #2241

merged 1 commit into from
Mar 15, 2023

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Mar 10, 2023 •
edited
Loading

Use new lib to validate blocks https://github.com/web3-storage/car-block-validator so that we can support all the hashers. Alternatively, we can block on linkdex getDagStructure which currently is done in waitUntil.

Thoughts?

@vasco-santos vasco-santos requested a review from a team as a code owner March 10, 2023 14:34
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023 •
edited
Loading

Website preview 🔗✨

build log

@vasco-santos vasco-santos force-pushed the fix/use-car-block-validator branch from fa7bc46 to f76a7fd Compare March 10, 2023 14:41
@github-actions
Copy link
Contributor

package-lock.json changes

Click to toggle table visibility
Name Status Previous Current
@multiformats/blake2 ADDED - 1.0.13
@multiformats/sha3 ADDED - 2.0.15
@web3-storage/car-block-validator ADDED - 1.0.0
js-sha3 ADDED - 0.8.0

@vasco-santos vasco-santos requested a review from olizilla March 10, 2023 15:34
gobengo
gobengo approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@gobengo gobengo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@gobengo gobengo changed the title fix: use car block validtor fix: use car block validator Mar 14, 2023
olizilla
olizilla approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vasco-santos vasco-santos merged commit 13fcc6c into main Mar 15, 2023
@vasco-santos vasco-santos deleted the fix/use-car-block-validator branch March 15, 2023 07:01
@github-actions github-actions bot mentioned this pull request Mar 15, 2023
Merged
vasco-santos pushed a commit that referenced this pull request Mar 15, 2023
@github-actions
chore(main): release api 7.15.3 (#2249)
b13d9b9 
🤖 I have created a release *beep* *boop*
---


##
[7.15.3](api-v7.15.2...api-v7.15.3)
(2023-03-15)


### Bug Fixes

* use car block validator
([#2241](#2241))
([13fcc6c](13fcc6c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla olizilla approved these changes

@gobengo gobengo gobengo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasco-santos @olizilla @gobengo