fix: upload type in upload should be blob or directory #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
requested review from
olizilla and
alanshaw
and removed request for
olizilla
|
Let's introduce a new |
olizilla
suggested changes
Sep 24, 2021
Co-authored-by: Oli Evans <[email protected]>
olizilla
approved these changes
Sep 24, 2021
vasco-santos
deleted the
fix/upload-type-in-upload-route-should-be-blob-or-directory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR to unify /car and /upload #480 was merged and changed the Upload type provided to the Database from
Directory/BlobtoUpload, keepingCarto when using the /car endpoint.This is causing problems in production because
enum type 'UploadType'. Known values are: Car, Blob, Multipartper https://github.com/web3-storage/web3.storage/blob/website-v1.4.0/packages/db/fauna/schema.graphql#L262-L274This PR reverts this back to the original behaviour. However, given everything is going to be stored as a Car, maybe the best solution is to either drop this property, or really change its type to
Uploadin the Database schema.