fix: chunked backup creation #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olizilla
reviewed
Sep 27, 2021
| }, | ||
| If( | ||
| IsNonEmpty(Var('backupMatch')), | ||
| Get(Var('backupMatch')), |
There was a problem hiding this comment.
to verify my understanding here, the true_expr in this If ... Get(Var('backupMatch')),is basically unused right? it's just there because Fauna doesn't support a simple If...then only an If...then...else.
There was a problem hiding this comment.
yes sir! I "return" the Backup because the Create below also returns the Backup, either way nothing uses the returned value
olizilla
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#417 was merged but follow up chunk backup URLs were not properly stored. Only the first one was stored, instead of each single one. This was because of the short circuit where we just return an upload if there is one. In this situation, we need to update the Backup collection
Considering comment #417 (comment) , an index was also added to verify if the backup url for the given upload already exists. Considering that we will not create the upload entry and we will not create the content entry, this should not result in much more computing power to finish the mutation.