Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increment used storage #501

Merged
merged 3 commits into from
Sep 28, 2021
Merged

fix: increment used storage #501

merged 3 commits into from
Sep 28, 2021

Conversation

vasco-santos
Copy link
Contributor

No description provided.

@vasco-santos vasco-santos marked this pull request as ready for review September 28, 2021 16:07
Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please restore incrementUserUsedStorage.js as in theory we'd want to be able to deploy the db and have the current api version still work against it, and in practice our fauna import task only adds and updates things, it does not delete, so removing it from our code base will mean the prod db has an extra function that a dev db may not.

Copy link
Contributor

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@olizilla olizilla merged commit 1becd09 into main Sep 28, 2021
@olizilla olizilla deleted the fix/increment-used-storage branch September 28, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants