chore: cron and pinpin rewire #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
chore/cron-rewire
branch
10 times, most recently
from
e57ae8f to
36ac294
Compare
vasco-santos
force-pushed
the
chore/cron-rewire
branch
from
e758250 to
364faed
Compare
vasco-santos
commented
Oct 14, 2021
vasco-santos
force-pushed
the
chore/cron-rewire
branch
4 times, most recently
from
7773461 to
2ed9432
Compare
|
Updated DB:
|
vasco-santos
force-pushed
the
chore/cron-rewire
branch
2 times, most recently
from
907a43f to
74af489
Compare
vasco-santos
force-pushed
the
chore/cron-rewire
branch
from
74af489 to
f5f99bd
Compare
vasco-santos
force-pushed
the
chore/cron-rewire
branch
2 times, most recently
from
102cf52 to
bec04a2
Compare
vasco-santos
force-pushed
the
chore/cron-rewire
branch
from
bec04a2 to
2a3c4ce
Compare
hugomrdias
approved these changes
Oct 21, 2021
alanshaw
approved these changes
Oct 22, 2021
vasco-santos
added a commit
that referenced
this pull request
Oct 22, 2021
vasco-santos
added a commit
that referenced
this pull request
Oct 22, 2021
vasco-santos
added a commit
that referenced
this pull request
Oct 22, 2021
Merged
vasco-santos
added a commit
that referenced
this pull request
Oct 22, 2021
vasco-santos
added a commit
that referenced
this pull request
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewires cron jobs and also pinpin because why not!? Needed functions were added to the DB Client to ease the transition between Fauna and Postgres with the env variable like before.
This PR includes:
The DB now includes tests that "simulate" the same flows that the cron jobs do. However, we should also create a test environment for these mocking DB to have better testing guarantees. Let me know if you agree and I will create an issue to track it.
Needs:
Closes #520