Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deal normalize should filter out unexpected deal status #682

Merged
merged 4 commits into from
Nov 23, 2021
Merged

fix: deal normalize should filter out unexpected deal status #682

merged 4 commits into from
Nov 23, 2021

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented Nov 23, 2021 •
edited
Loading

Per #677 (review) filters out deals with other status.

Also normalizes activation and termination per:

alanshaw
alanshaw approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think there's a mock that needs to be updated though...

@vasco-santos
Copy link
Contributor Author

yeah, did not realize that. ready

@vasco-santos vasco-santos merged commit 0e233cc into main Nov 23, 2021
@vasco-santos vasco-santos deleted the fix/deal-normalize-should-filter-out-unexpected-deal-status branch November 23, 2021 17:46
@github-actions github-actions bot mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @alanshaw