Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpProvider#sendAsync removed in 1.0.0-beta.30 #1451

Closed
Freyert opened this issue Mar 12, 2018 · 2 comments
Closed

HttpProvider#sendAsync removed in 1.0.0-beta.30 #1451

Freyert opened this issue Mar 12, 2018 · 2 comments
Assignees

Comments

@Freyert
Copy link
Contributor

Freyert commented Mar 12, 2018

The HttpProvider's prototype is being overwritten by: [email protected]. This removes the sendAsync method from the provider.

truffle has a dependency on sendAsync.

trufflesuite/truffle-provider#12

@Freyert Freyert changed the title Prototype Clobbering in 1.0.0-beta.30 HttpProvider#sendAsync removed in 1.0.0-beta.30 Mar 12, 2018
@nivida nivida self-assigned this Aug 9, 2018
@vongohren
Copy link

vongohren commented Oct 5, 2018

So do etherjs rpc, that some libraries depend on.
https://github.com/ethjs/ethjs-rpc/blob/master/src/index.js#L46

So if I use these libraries, send in my provider from web3, then it crashes down the stack, because sendAsync cannot be called.

Im using ethr-did-resolver now, and they use ethjs in the background.

@nivida
Copy link
Contributor

nivida commented Nov 28, 2018

sendAsync will no longer exist and also the provider's methods are not a part of public API that's why they are not documented. I think it would be good to just use the send method. Because of this I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants