Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment box issues with long comments #1622

Closed
karlcow opened this issue Jun 28, 2017 · 8 comments
Closed

Comment box issues with long comments #1622

karlcow opened this issue Jun 28, 2017 · 8 comments

Comments

@karlcow
Copy link
Member

karlcow commented Jun 28, 2017

Step to reproduce

  1. Go to an issue
  2. Start typing a comment so you reach the bottom of the allocated space
  3. insert an image

Issues List

  1. Actual: Note how the image is added under the visible part of the textarea. Expected: the textarea should be positioned so we can see the code we just added.
  2. Actual: You can't scroll in the textarea to view the code. Expected. Scroll down. The only way is to use the arrow key.
  3. Once the textarea is bigger than the viewport and your page is scrolled to the bottom (aka end of textarea above the end of the viewport) and you type. Actual: The textarea bottom jumps to the bottom of the page. Expected: The textarea should be in place.
  4. Bonus issue: When the cursor is somewhere in the comment. It should be the insertion point of the image. The image is always added at the end of the comment.

I can open separate issues for each of them.

@karlcow
Copy link
Member Author

karlcow commented Jun 28, 2017

Some issues are possibly related to what we decided in #1211
Sorry… @zoepage 😿 👹

@zoepage
Copy link
Member

zoepage commented Jul 10, 2017

After a conversation with @karlcow, we've decided to remove the feature as we it feels more like a bug and not a feature.

@zoepage zoepage self-assigned this Jul 31, 2017
@apoorvasingh17
Copy link
Contributor

Hello....I'm a beginner and would like to work on this issue. How should I get started?

@denschub
Copy link
Member

@apoorvasingh17 Check my comment over here!

@miketaylr
Copy link
Member

After a conversation with @karlcow, we've decided to remove the feature as we it feels more like a bug and not a feature.

@zoepage does this mean we should close the issue? Or do we need to write patches to remove...something?

@miketaylr
Copy link
Member

Ah, I think that means we want to remove the autoExpand thingy?

#1636 (comment)

@karlcow
Copy link
Member Author

karlcow commented Aug 15, 2017

@miketaylr confirmed. Remove the autoexpand. It is not working as it is right now.

@zoepage
Copy link
Member

zoepage commented Sep 18, 2017

As this was fixed in #1636, closing,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants