Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The <acceptable use> link redirects to a 404 page #3186

Closed
softvision-sergiulogigan opened this issue Feb 7, 2020 · 3 comments
Closed

The <acceptable use> link redirects to a 404 page #3186

softvision-sergiulogigan opened this issue Feb 7, 2020 · 3 comments
Assignees

Comments

@softvision-sergiulogigan
Copy link
Collaborator

softvision-sergiulogigan commented Feb 7, 2020

After logging an issue, the page that the user gets is the bug shell - "In moderation queue".
The link redirects to a 404 page.
https://webcompat.com/terms#acceptable-use

image

@softvision-sergiulogigan softvision-sergiulogigan changed the title The <acceptable use> link redirects to a 404 page. The <acceptable use> link redirects to a 404 page Feb 7, 2020
@softvision-sergiulogigan
Copy link
Collaborator Author

Also
image

@ksy36
Copy link
Contributor

ksy36 commented Feb 7, 2020

I think this #3168 hasn't been deployed on production yet

@karlcow karlcow self-assigned this Feb 10, 2020
@karlcow
Copy link
Member

karlcow commented Feb 10, 2020

the route exists

@app.route('/terms')
@cache_policy(private=True, uri_max_age=0, must_revalidate=True)
def terms():
"""Route to display terms of service page."""
if g.user:
get_user_info()
return render_template('terms.html')

Added by https://github.com/webcompat/webcompat.com/pull/3168/files

this is deployed already on staging.

but as @ksy36 this is not yet in production

https://webcompat.com/terms#acceptable-use vs https://staging.webcompat.com/terms#acceptable-use

and we are forced to use a fully qualified domain name because of github.

@karlcow karlcow closed this as completed Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants