event patching not working on shadowRoot (removeEventListener)

[valdrinkoshi]

event patching is not working properly for element shadowRoots, in particular event listeners aren't removed. e.g. See the following repro on Firefox http://jsbin.com/mizatey/2/edit?html,output

var logger = function(event) { console.log('clicked!', event) };
var el = document.createElement('div');
el.attachShadow({mode: 'open'}).innerHTML = 'click me';
document.body.appendChild(el);
el.shadowRoot.addEventListener('click', logger);
el.shadowRoot.removeEventListener('click', logger);

Try clicking on the element and notice that logger keeps being invoked.

[sorvell]

@azakus It looks to me like the problem is where we store the listener info . We're always storing this as the target node, but this should be target which is specially set when we're listening on a shadowRoot. We do correctly pass this same specially set target when we try to find the listener in removeEventListener. Does that sound right?

[valdrinkoshi]

Verified the fix for the issue originally raised in predixdesignsystem/px-data-grid#331 and it does fix it 👌

[talimarcus]

Any update/ETA on this?

[talimarcus]

Sweet, checked the fix with PolymerElements/iron-a11y-keys#44 and it worked 👍 Can we get a tag for this please?