Skip to content

Commit

Permalink
Bumb default geckodriver version (#77)
Browse files Browse the repository at this point in the history
* update default driver to 0.28.0

* 1.21.0
  • Loading branch information
dmlemeshko authored Nov 18, 2020
1 parent 8007425 commit 7e68708
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ Use `GECKODRIVER_SKIP_DOWNLOAD` to skip the download of the geckodriver file.
## Versions

* [npm module version] - [geckodriver version]
* 1.21.x - geckodriver 0.28.0
* 1.20.x - geckodriver 0.27.0
* 1.19.x - geckodriver 0.26.0
* 1.18.x - geckodriver 0.26.0
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ if (skipDownload === 'true') {
var baseCDNURL = process.env.GECKODRIVER_CDNURL || process.env.npm_config_geckodriver_cdnurl || 'https://github.com/mozilla/geckodriver/releases/download';
var CACHED_ARCHIVE = process.env.GECKODRIVER_FILEPATH ? path.resolve(process.env.GECKODRIVER_FILEPATH) : undefined;

var version = process.env.GECKODRIVER_VERSION || process.env.npm_config_geckodriver_version || '0.27.0';
var version = process.env.GECKODRIVER_VERSION || process.env.npm_config_geckodriver_version || '0.28.0';

// Remove trailing slash if included
baseCDNURL = baseCDNURL.replace(/\/+$/, '');
Expand Down
2 changes: 1 addition & 1 deletion lib/geckodriver.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ process.env.PATH += path.delimiter + path.join(__dirname, '..');
exports.path = process.platform === 'win32' ? path.join(__dirname, '..', 'geckodriver.exe') : path.join(__dirname, '..', 'geckodriver');

// specify the version of geckodriver
exports.version = process.env.GECKODRIVER_VERSION || '0.26.0';
exports.version = process.env.GECKODRIVER_VERSION || '0.28.0';

exports.start = function(args) {
exports.defaultInstance = require('child_process').execFile(exports.path, args);
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "geckodriver",
"version": "1.20.0",
"version": "1.21.0",
"description": "Downloader for https://github.com/mozilla/geckodriver/releases",
"scripts": {
"test": "ava",
Expand Down

0 comments on commit 7e68708

Please sign in to comment.