From 7e68708c8e368e5a864c5543ea266ac14f557cae Mon Sep 17 00:00:00 2001 From: Dmitry Date: Thu, 19 Nov 2020 00:59:49 +0100 Subject: [PATCH] Bumb default geckodriver version (#77) * update default driver to 0.28.0 * 1.21.0 --- README.md | 1 + index.js | 2 +- lib/geckodriver.js | 2 +- package-lock.json | 2 +- package.json | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 4e7de548..66ccc28b 100644 --- a/README.md +++ b/README.md @@ -85,6 +85,7 @@ Use `GECKODRIVER_SKIP_DOWNLOAD` to skip the download of the geckodriver file. ## Versions * [npm module version] - [geckodriver version] +* 1.21.x - geckodriver 0.28.0 * 1.20.x - geckodriver 0.27.0 * 1.19.x - geckodriver 0.26.0 * 1.18.x - geckodriver 0.26.0 diff --git a/index.js b/index.js index 309a4022..37222a34 100644 --- a/index.js +++ b/index.js @@ -22,7 +22,7 @@ if (skipDownload === 'true') { var baseCDNURL = process.env.GECKODRIVER_CDNURL || process.env.npm_config_geckodriver_cdnurl || 'https://github.com/mozilla/geckodriver/releases/download'; var CACHED_ARCHIVE = process.env.GECKODRIVER_FILEPATH ? path.resolve(process.env.GECKODRIVER_FILEPATH) : undefined; -var version = process.env.GECKODRIVER_VERSION || process.env.npm_config_geckodriver_version || '0.27.0'; +var version = process.env.GECKODRIVER_VERSION || process.env.npm_config_geckodriver_version || '0.28.0'; // Remove trailing slash if included baseCDNURL = baseCDNURL.replace(/\/+$/, ''); diff --git a/lib/geckodriver.js b/lib/geckodriver.js index 7e9b8977..b8cfa9e3 100644 --- a/lib/geckodriver.js +++ b/lib/geckodriver.js @@ -7,7 +7,7 @@ process.env.PATH += path.delimiter + path.join(__dirname, '..'); exports.path = process.platform === 'win32' ? path.join(__dirname, '..', 'geckodriver.exe') : path.join(__dirname, '..', 'geckodriver'); // specify the version of geckodriver -exports.version = process.env.GECKODRIVER_VERSION || '0.26.0'; +exports.version = process.env.GECKODRIVER_VERSION || '0.28.0'; exports.start = function(args) { exports.defaultInstance = require('child_process').execFile(exports.path, args); diff --git a/package-lock.json b/package-lock.json index acd90829..09bcffa6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "geckodriver", - "version": "1.20.0", + "version": "1.21.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 89d28302..49170290 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "geckodriver", - "version": "1.20.0", + "version": "1.21.0", "description": "Downloader for https://github.com/mozilla/geckodriver/releases", "scripts": { "test": "ava",