Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getLocalIdent now accepts false value #865

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #862

Breaking Changes

No

Additional Info

Regression

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #865 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          10       10           
  Lines         370      370           
  Branches      104      104           
=======================================
  Hits          368      368           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 634ab49...7862439. Read the comment docs.

@alexander-akait alexander-akait merged commit 1825e8a into master Dec 10, 2018
@alexander-akait alexander-akait deleted the issue-862 branch December 10, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0.0] getLocalIdent validation
1 participant