refactor: Apply webpack-defaults & webpack 3.x support #540

joshwiens · 2017-06-11T00:35:10Z

Working PR for the 3.x release branch

Beta & RC builds should be published from this branch to the @beta npm dist-tag

Squashed commit message body for merge and 3.0.0 release


- refactor: Pass a unique compiler name to get child compilation [483](https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/483)
- refactor: Apply webpack-defaults [542](https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/542)

BREAKING CHANGE: Enforces `engines` of `"node": ">=4.3.0 < 5.0.0 || >= 5.10`

- refactor: DeprecationWarning: Chunk.modules [543](https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/543)

BREAKING CHANGE: Updates to `Chunk.mapModules`. This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764

- fix: css generation order issue see: webpack/webpack#5225

BREAKING CHANGE: Enforces `peerDependencies` of `"webpack": "^3.1.0"`.

Closes #529
Closes #548

This is recommended after webpack/webpack#4704

michael-ciniawsky · 2017-06-20T15:31:08Z

package.json

@@ -35,7 +35,7 @@
    "should": "^11.1.2",
    "standard-version": "^4.1.0",
    "style-loader": "^0.18.2",
-    "webpack": "^2.6.1"
+    "webpack": "^3.0.0-rc.0"


This is removed in #542

michael-ciniawsky · 2017-06-20T15:31:42Z

@d3viant0ne Would this be ready as a MVP ?

joshwiens · 2017-06-20T23:05:48Z

breaking is not a semver type, please leave the title of this PR alone. Breaking changes are handled via the body of the commit message which you can find in the bottom of the original post

codecov · 2017-07-07T07:02:12Z

Codecov Report

Merging #540 into master will decrease coverage by 2.72%.
The diff coverage is 87.41%.

@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   90.14%   87.41%   -2.73%     
==========================================
  Files           4        7       +3     
  Lines         355      302      -53     
  Branches       75       68       -7     
==========================================
- Hits          320      264      -56     
- Misses         35       36       +1     
- Partials        0        2       +2

Impacted Files	Coverage Δ
src/cjs.js	`0% <0%> (ø)`
src/lib/OrderUndefinedError.js	`14.28% <14.28%> (ø)`
src/lib/ExtractedModule.js	`88.57% <88.57%> (ø)`
src/loader.js	`88.7% <88.7%> (ø)`
src/index.js	`89.7% <89.7%> (ø)`
src/lib/helpers.js	`89.74% <89.74%> (ø)`
src/lib/ExtractTextPluginCompilation.js	`90.9% <90.9%> (ø)`
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd43832...6b4e64c. Read the comment docs.

michael-ciniawsky · 2017-07-07T14:25:24Z

src/index.js

+      compilation.plugin('additional-assets', (callback) => {
+        extractedChunks.forEach((extractedChunk) => {
+          if (extractedChunk.getNumberOfModules()) {
+            extractedChunk.modules.sort((a, b) => {


extractedChunk.modules.sort => extractedChunk.sortModules ?

Think we have the same idea, we'll know in a minute.

michael-ciniawsky

If it stays family friendly over the weekend g2g 😛

ThePumpingLemma · 2017-07-08T20:08:52Z

src/index.js

+        async.forEach(chunks, (chunk, callback) => { // eslint-disable-line no-shadow
+          const extractedChunk = extractedChunks[chunks.indexOf(chunk)];
+          const shouldExtract = !!(options.allChunks || isInitialOrHasNoParents(chunk));
+          chunk.sortModules(module);


I'm seeing #565 in a webpack project at $WORK. I don't think you should be passing in module to sortModules (since it doesn't seem to be a comparator function) and making this change fixes the aforementioned problem for me.

Can you provide more info about your setup please? webpack.config.js etc ? Do you use karma somewhere (#554) ?

No, we don't use karma anywhere. I can try and scrub the config so I can post it, but it will be a bit of a pain.

This particular reference is to Node's current module object since there are no other references to module in this scope (from what I can tell anyway). Is the sort intended to be called during mapModules?

joshwiens · 2017-07-10T01:40:02Z

For everyone watching, I'll be publishing what should be the final rc build shortly. Still planning on putting this on the dist-tag tomorrow evening.

codecov-io · 2017-07-10T02:17:49Z

Codecov Report

Merging #540 into master will decrease coverage by 2.72%.
The diff coverage is 87.41%.

@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   90.14%   87.41%   -2.73%     
==========================================
  Files           4        7       +3     
  Lines         355      302      -53     
  Branches       75       68       -7     
==========================================
- Hits          320      264      -56     
- Misses         35       36       +1     
- Partials        0        2       +2

Impacted Files	Coverage Δ
src/cjs.js	`0% <0%> (ø)`
src/lib/OrderUndefinedError.js	`14.28% <14.28%> (ø)`
src/lib/ExtractedModule.js	`88.57% <88.57%> (ø)`
src/loader.js	`88.7% <88.7%> (ø)`
src/index.js	`89.7% <89.7%> (ø)`
src/lib/helpers.js	`89.74% <89.74%> (ø)`
src/lib/ExtractTextPluginCompilation.js	`90.9% <90.9%> (ø)`
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd43832...6b4e64c. Read the comment docs.

refactor: pass a unique compiler name to get child compilation (#483)

77daf83

This is recommended after webpack/webpack#4704

joshwiens added priority: 2 (urgent) semver: Major type: Refactor labels Jun 11, 2017

chore(package): Update peerDeps & webpack devDep

92e4349

joshwiens changed the title ~~refactor: Support Webpack 3.x (#483)~~ feat: Support Webpack 3.x (#483) Jun 11, 2017

joshwiens added type: Feature and removed type: Refactor labels Jun 11, 2017

joshwiens changed the title ~~feat: Support Webpack 3.x (#483)~~ feat: Support Webpack 3.x Jun 11, 2017

joshwiens mentioned this pull request Jun 15, 2017

refactor: Apply webpack-defaults #542

Merged

4 tasks

yveskaufmann mentioned this pull request Jun 20, 2017

Initial Webpack3 support jantimon/html-webpack-plugin#706

Closed

mastilver mentioned this pull request Jun 20, 2017

Update to webpack 3 jantimon/html-webpack-plugin#707

Merged

michael-ciniawsky mentioned this pull request Jun 20, 2017

fix: split async CSS correctly #546

Closed

michael-ciniawsky reviewed Jun 20, 2017

View reviewed changes

michael-ciniawsky changed the title ~~feat: Support Webpack 3.x~~ breaking(package): update peerDependencies (webpack v2.0.0..3.0.0) Jun 20, 2017

michael-ciniawsky added priority: 1 (critical) pr_action: Review status: Pending type: Chore and removed priority: 2 (urgent) type: Feature labels Jun 20, 2017

michael-ciniawsky added this to the 3.0.0 milestone Jun 20, 2017

michael-ciniawsky requested review from bebraw, alexander-akait and michael-ciniawsky June 20, 2017 15:37

michael-ciniawsky mentioned this pull request Jun 20, 2017

Webpack 3 release #549

Closed

joshwiens changed the title ~~breaking(package): update peerDependencies (webpack v2.0.0..3.0.0)~~ refactor: Apply webpack-defaults & webpack 3.x support Jun 20, 2017

joshwiens added the type: Refactor label Jun 20, 2017

joshwiens added 3 commits July 7, 2017 00:50

chore(release): 3.0.0-rc.0

b70c6ec

test: Fix order by id test

2c2f12b

test: Add nested order by id test

28363ab

webpack-contrib deleted a comment from codecov bot Jul 7, 2017

michalkvasnicak mentioned this pull request Jul 7, 2017

⚡ Support for webpack 3 michalkvasnicak/spust#21

Closed

1 task

michael-ciniawsky reviewed Jul 7, 2017

View reviewed changes

fix: Module sorting

27e3a28

joshwiens force-pushed the feature/webpack3 branch from 5813cc7 to 27e3a28 Compare July 7, 2017 15:02

michael-ciniawsky and others added 3 commits July 7, 2017 10:28

test: Failing test for css ordering (#564)

1f057e1

test: fix expected for css order test

7f46af0

chore(release): 3.0.0-rc.1

29e1b4c

michael-ciniawsky approved these changes Jul 7, 2017

View reviewed changes

This was referenced Jul 7, 2017

refactor: cache assets similar to how the normal compilation does it #325

Closed

refactor: don't throw errors in case of child context #390

Closed

feat: allow to log invalid orders as warnings instead of errors via option #81

Closed

jakedowns mentioned this pull request Jul 7, 2017

Windows Git Bash: mix.sass() Failed to compile: dependency not found laravel-mix/laravel-mix#974

Closed

ThePumpingLemma reviewed Jul 8, 2017

View reviewed changes

fix: Modules shouldn't be passed to sort (#568)

113cabb

chore(release): 3.0.0-rc.2

6b4e64c

joshwiens added pr_action: Merge ready and removed pr_action: Review labels Jul 10, 2017

joshwiens merged commit 7ae32d9 into master Jul 10, 2017

joshwiens deleted the feature/webpack3 branch July 11, 2017 21:15

michael-ciniawsky modified the milestone: 4.0.0 Aug 31, 2017

rdy mentioned this pull request Dec 21, 2017

refactor(loader): do not throw errors in case of child context #688

Closed

snyk-bot mentioned this pull request Mar 2, 2020

[Snyk] Upgrade extract-text-webpack-plugin from 3.0.0 to 3.0.2 DavidKindler/burger-builder#37

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Apply webpack-defaults & webpack 3.x support #540

refactor: Apply webpack-defaults & webpack 3.x support #540

joshwiens commented Jun 11, 2017 •

edited

Loading

michael-ciniawsky Jun 20, 2017

joshwiens Jun 20, 2017

michael-ciniawsky commented Jun 20, 2017

joshwiens commented Jun 20, 2017 •

edited

Loading

codecov bot commented Jul 7, 2017 •

edited

Loading

michael-ciniawsky Jul 7, 2017

joshwiens Jul 7, 2017

michael-ciniawsky left a comment

ThePumpingLemma Jul 8, 2017 •

edited

Loading

michael-ciniawsky Jul 8, 2017 •

edited

Loading

ThePumpingLemma Jul 8, 2017

joshwiens commented Jul 10, 2017

codecov-io commented Jul 10, 2017 •

edited

Loading

refactor: Apply webpack-defaults & webpack 3.x support #540

refactor: Apply webpack-defaults & webpack 3.x support #540

Conversation

joshwiens commented Jun 11, 2017 • edited Loading

michael-ciniawsky Jun 20, 2017

Choose a reason for hiding this comment

joshwiens Jun 20, 2017

Choose a reason for hiding this comment

michael-ciniawsky commented Jun 20, 2017

joshwiens commented Jun 20, 2017 • edited Loading

codecov bot commented Jul 7, 2017 • edited Loading

Codecov Report

michael-ciniawsky Jul 7, 2017

Choose a reason for hiding this comment

joshwiens Jul 7, 2017

Choose a reason for hiding this comment

michael-ciniawsky left a comment

Choose a reason for hiding this comment

ThePumpingLemma Jul 8, 2017 • edited Loading

Choose a reason for hiding this comment

michael-ciniawsky Jul 8, 2017 • edited Loading

Choose a reason for hiding this comment

ThePumpingLemma Jul 8, 2017

Choose a reason for hiding this comment

joshwiens commented Jul 10, 2017

codecov-io commented Jul 10, 2017 • edited Loading

Codecov Report

joshwiens commented Jun 11, 2017 •

edited

Loading

joshwiens commented Jun 20, 2017 •

edited

Loading

codecov bot commented Jul 7, 2017 •

edited

Loading

ThePumpingLemma Jul 8, 2017 •

edited

Loading

michael-ciniawsky Jul 8, 2017 •

edited

Loading

codecov-io commented Jul 10, 2017 •

edited

Loading