refactor: `Chunk.modules` => `Chunk.mapModules` (`webpack v3.0.0`) #543

MirrorBytes · 2017-06-13T03:28:02Z

Refactors to use webpack 3.x Chunk.mapModules

Closes #529

Squashed commit message body for merge


- refactor: DeprecationWarning: Chunk.modules

BREAKING CHANGE: Updates to `Chunk.mapModules`. This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764

Updating

fix: add missing `options.ignoreOrder` details in Error message (webpack-contrib#539)

Feature/webpack3

joshwiens · 2017-06-13T03:56:23Z

index.js

@@ -269,7 +269,7 @@ ExtractTextPlugin.prototype.apply = function(compiler) {
 			async.forEach(chunks, function(chunk, callback) {
 				var extractedChunk = extractedChunks[chunks.indexOf(chunk)];
 				var shouldExtract = !!(options.allChunks || isInitialOrHasNoParents(chunk));
-				async.forEach(chunk.modules.slice(), function(module, callback) {
+				async.forEach(chunk.mapModules(function(c) { return c; }), function(module, callback) {


Having just refactored this entire plugin, there are 4/5 instances of chunk.modules.something

How about function (m) { return m; } for precise initials?

c === chunk the naming convention is as it should be

mapModules map functions on each module so the iteratee will be called with each module. See https://github.com/webpack/webpack/pull/4764/files#diff-8941681d920ac4feda44f522b986c2d0R115

michael-ciniawsky · 2017-06-13T04:48:37Z

This will land in the v2.x line fixing the Deprecation Warning , before webpack-defaults (v3.0.0) lands? :) I'm a bit confused 😛

joshwiens · 2017-06-13T04:58:02Z

@michael-ciniawsky - This change is not backwards compatible with 2.x hence why it's targeting the features/webpack3.

This can merge into that target branch when ready & I can rebase in the changes to the defaults PR.

MirrorBytes · 2017-06-14T23:31:11Z

@d3viant0ne I'll change all of the instances accordingly. Sound good?

michael-ciniawsky · 2017-06-20T15:34:53Z

@MirrorBytes What is missing here, did you find the remaining places, where this needs to be updated as @d3viant0ne suggested?

alexander-akait · 2017-06-20T15:38:09Z

@michael-ciniawsky maybe we can check webpack version and use difference behavior without breaking changes?

michael-ciniawsky · 2017-06-20T15:59:57Z

@evilebottnawi How would this look like ? There is this.version (at least in the Loader API), so maybe

function mapModules (chunk) {
   if (this.version >= 3) return chunk.mapModule((c) => c)
   return chunk.modules.slice()
}

or check the chunk for extisting methods would work 😛

alexander-akait · 2017-06-20T16:18:05Z

@michael-ciniawsky seems good, but need wait what says @d3viant0ne

michael-ciniawsky · 2017-06-20T16:52:30Z

Fixes #494

joshwiens · 2017-06-21T01:30:16Z

@MirrorBytes - This will need to be rebased now that the defaults PR has landed.

Don't know how good you are with git, if you aren't comfortable doing it just give me write permission ( hit edit in this pr & you should see a check box ) and I will rebase it for you.

themre · 2017-06-22T06:28:15Z

I hear appveyor has some issues lately. perhaps someone else can run it on windows to release it.

bobvanderlinden · 2017-06-22T09:15:57Z

I rebased this PR on feature/webpack3 and changed the remaining references to Chunk.modules to Chunk.mapModules. The resulting version can be found here: https://github.com/bobvanderlinden/extract-text-webpack-plugin/commits/pr-543

With the additional changes, the test does not output any warnings like it did before:

(node:3880) DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead.

I ran the tests on Windows 10, node v6.4.0, webpack 3.0.0.
1 test failed:

Expected value to equal:
  "body {
        correct: a;
}
body {
        correct: b;
}

/*# sourceMappingURL=file.css.map*/"
Received:
  "body {
        correct: a;
}
body {
        correct: b;
}

/*# sourceMappingURL=file.css.map*/"

Difference:

- Expected
+ Received

@@ -2,7 +2,7 @@
        correct: a;
 }
 body {
        correct: b;
 }
-
+
 /*# sourceMappingURL=file.css.map*/

Note though that this seems unrelated to this PR as the test also fails on feature/webpack3. I'm guessing it's an \r\n vs \n problem?

joshwiens · 2017-06-22T23:29:24Z

I'll try to take a look at the windows issue tonight.

c0b41 · 2017-06-28T08:32:46Z

any status?

cklmercer · 2017-06-28T19:03:59Z

Not sure if this is related but I recently started encountering the following issue on Windows 10.

TypeError: chunk.mapModules is not a function
    at C:\Users\me\Code\xxx\xxx.com\node_modules\webpack\lib\HotModuleReplacementPlugin.js:59:46
    at Array.forEach (native)
    at Compilation.<anonymous> (C:\Users\me\Code\xxx\xxx.com\node_modules\webpack\lib\HotModuleReplacementPlugin.js:58:16)
    at Compilation.applyPlugins2 (C:\Users\me\Code\xxx\xxx.com\node_modules\tapable\lib\Tapable.js:82:14)
    at sealPart2 (C:\Users\me\Code\xxx\xxx.com\node_modules\webpack-dev-server\node_modules\webpack\lib\Compilation.js:629:10)
    at next (C:\Users\me\Code\xxx\xxx.com\node_modules\tapable\lib\Tapable.js:138:11)
    at Compilation.compilation.plugin (C:\Users\me\Code\xxx\xxx.com\node_modules\webpack-dev-server\node_modules\webpack\lib\ProgressPlugin.js:109:6)
    at Compilation.applyPluginsAsyncSeries (C:\Users\me\Code\xxx\xxx.com\node_modules\tapable\lib\Tapable.js:142:13)
    at Compilation.seal (C:\Users\me\Code\xxx\xxx.com\node_modules\webpack-dev-server\node_modules\webpack\lib\Compilation.js:579:8)
    at C:\Users\me\Code\xxx\xxx.com\node_modules\webpack-dev-server\node_modules\webpack\lib\Compiler.js:493:16

joshwiens · 2017-07-07T05:18:34Z

This has been taken care of in another PR given the time pressure to get etwp stable in Webpack 3.x

- refactor: Pass a unique compiler name to get child compilation [483](#483) - refactor: Apply webpack-defaults [542](#542) BREAKING CHANGE: Enforces `engines` of `"node": ">=4.3.0 < 5.0.0 || >= 5.10` - refactor: DeprecationWarning: Chunk.modules [543](#543) BREAKING CHANGE: Updates to `Chunk.mapModules`. This release is not backwards compatible with `Webpack 2.x` due to breaking changes in webpack/webpack#4764 - fix: css generation order issue see: webpack/webpack#5225 BREAKING CHANGE: Enforces `peerDependencies` of `"webpack": "^3.1.0"`.

MirrorBytes added 5 commits June 8, 2017 02:26

Quick fix for [ENOENT: "./schema/loader.json"]

9c78c43

Merge pull request #1 from webpack-contrib/master

018da67

Updating

Merge pull request #2 from webpack-contrib/master

037bfb6

fix: add missing `options.ignoreOrder` details in Error message (webpack-contrib#539)

Merge pull request #3 from webpack-contrib/feature/webpack3

04c8ae8

Feature/webpack3

mapModules fix

fb8e098

joshwiens reviewed Jun 13, 2017

View reviewed changes

joshwiens mentioned this pull request Jun 13, 2017

refactor: Apply webpack-defaults & webpack 3.x support #540

Merged

12 tasks

matanwerbner mentioned this pull request Jun 20, 2017

Fixes #19478 - migrate to webpack2 theforeman/foreman#4514

Merged

michael-ciniawsky mentioned this pull request Jun 20, 2017

fix: split async CSS correctly #546

Closed

michael-ciniawsky changed the title ~~fix(index): DeprecationWarning: Chunk.modules in Webpack 3.x~~ fix(index): Chunk.modules => Chunk.mapModules (webpack v3.0.0) Jun 20, 2017

michael-ciniawsky requested review from bebraw, alexander-akait and joshwiens June 20, 2017 15:35

michael-ciniawsky added this to the 3.0.0 milestone Jun 20, 2017

michael-ciniawsky added flag: Needs more info priority: 1 (critical) pr_action: Review semver: Major status: Pending type: Refactor labels Jun 20, 2017

michael-ciniawsky changed the title ~~fix(index): Chunk.modules => Chunk.mapModules (webpack v3.0.0)~~ breaking(index): Chunk.modules => Chunk.mapModules (webpack v3.0.0) Jun 20, 2017

michalkvasnicak mentioned this pull request Jun 20, 2017

⚡ Support for webpack 3 michalkvasnicak/spust#21

Closed

1 task

joshwiens changed the title ~~breaking(index): Chunk.modules => Chunk.mapModules (webpack v3.0.0)~~ refactor: Chunk.modules => Chunk.mapModules (webpack v3.0.0) Jun 21, 2017

themre mentioned this pull request Jun 22, 2017

Feature/webpack3 facebook/create-react-app#2574

Merged

SimulatedGREG mentioned this pull request Jun 30, 2017

Update to webpack@^3 SimulatedGREG/electron-vue#296

Closed

joshwiens closed this Jul 7, 2017

michael-ciniawsky modified the milestone: 4.0.0 Aug 31, 2017

This was referenced Feb 2, 2018

chore(deps): update dependency extract-text-webpack-plugin to v3 Pragmateam/coding-dojo#102

Merged

Update dependency extract-text-webpack-plugin to v3 JimmyLv/Haiku#35

Open

snyk-bot mentioned this pull request Mar 2, 2020

[Snyk] Upgrade extract-text-webpack-plugin from 3.0.0 to 3.0.2 DavidKindler/burger-builder#37

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: `Chunk.modules` => `Chunk.mapModules` (`webpack v3.0.0`) #543

refactor: `Chunk.modules` => `Chunk.mapModules` (`webpack v3.0.0`) #543

MirrorBytes commented Jun 13, 2017 •

edited by joshwiens

Loading

joshwiens Jun 13, 2017

JLHwung Jun 21, 2017

joshwiens Jun 23, 2017

JLHwung Jun 24, 2017 •

edited

Loading

michael-ciniawsky commented Jun 13, 2017 •

edited

Loading

joshwiens commented Jun 13, 2017

MirrorBytes commented Jun 14, 2017

michael-ciniawsky commented Jun 20, 2017

alexander-akait commented Jun 20, 2017

michael-ciniawsky commented Jun 20, 2017

alexander-akait commented Jun 20, 2017

michael-ciniawsky commented Jun 20, 2017

joshwiens commented Jun 21, 2017

themre commented Jun 22, 2017

bobvanderlinden commented Jun 22, 2017

joshwiens commented Jun 22, 2017

c0b41 commented Jun 28, 2017

cklmercer commented Jun 28, 2017

joshwiens commented Jul 7, 2017

refactor: Chunk.modules => Chunk.mapModules (webpack v3.0.0) #543

refactor: Chunk.modules => Chunk.mapModules (webpack v3.0.0) #543

Conversation

MirrorBytes commented Jun 13, 2017 • edited by joshwiens Loading

joshwiens Jun 13, 2017

Choose a reason for hiding this comment

JLHwung Jun 21, 2017

Choose a reason for hiding this comment

joshwiens Jun 23, 2017

Choose a reason for hiding this comment

JLHwung Jun 24, 2017 • edited Loading

Choose a reason for hiding this comment

michael-ciniawsky commented Jun 13, 2017 • edited Loading

joshwiens commented Jun 13, 2017

MirrorBytes commented Jun 14, 2017

michael-ciniawsky commented Jun 20, 2017

alexander-akait commented Jun 20, 2017

michael-ciniawsky commented Jun 20, 2017

alexander-akait commented Jun 20, 2017

michael-ciniawsky commented Jun 20, 2017

joshwiens commented Jun 21, 2017

themre commented Jun 22, 2017

bobvanderlinden commented Jun 22, 2017

joshwiens commented Jun 22, 2017

c0b41 commented Jun 28, 2017

cklmercer commented Jun 28, 2017

joshwiens commented Jul 7, 2017

refactor: `Chunk.modules` => `Chunk.mapModules` (`webpack v3.0.0`) #543

refactor: `Chunk.modules` => `Chunk.mapModules` (`webpack v3.0.0`) #543

MirrorBytes commented Jun 13, 2017 •

edited by joshwiens

Loading

JLHwung Jun 24, 2017 •

edited

Loading

michael-ciniawsky commented Jun 13, 2017 •

edited

Loading