Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

refactor: Chunk.modules => Chunk.mapModules (webpack v3.0.0) #543

Closed
wants to merge 5 commits into from
Closed

refactor: Chunk.modules => Chunk.mapModules (webpack v3.0.0) #543

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c78c43
Quick fix for [ENOENT: "./schema/loader.json"]
MirrorBytes Jun 8, 2017
018da67
Merge pull request #1 from webpack-contrib/master
MirrorBytes Jun 9, 2017
037bfb6
Merge pull request #2 from webpack-contrib/master
MirrorBytes Jun 13, 2017
04c8ae8
Merge pull request #3 from webpack-contrib/feature/webpack3
MirrorBytes Jun 13, 2017
fb8e098
mapModules fix
MirrorBytes Jun 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ ExtractTextPlugin.prototype.apply = function(compiler) {
async.forEach(chunks, function(chunk, callback) {
var extractedChunk = extractedChunks[chunks.indexOf(chunk)];
var shouldExtract = !!(options.allChunks || isInitialOrHasNoParents(chunk));
async.forEach(chunk.modules.slice(), function(module, callback) {
async.forEach(chunk.mapModules(function(c) { return c; }), function(module, callback) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having just refactored this entire plugin, there are 4/5 instances of chunk.modules.something

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about function (m) { return m; } for precise initials?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c === chunk the naming convention is as it should be

Copy link

@JLHwung JLHwung Jun 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapModules map functions on each module so the iteratee will be called with each module. See https://github.com/webpack/webpack/pull/4764/files#diff-8941681d920ac4feda44f522b986c2d0R115

var meta = module[NS];
if(meta && (!meta.options.id || meta.options.id === id)) {
var wasExtracted = Array.isArray(meta.content);
Expand Down