-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix some possible issues with file paths #377
Conversation
Codecov ReportBase: 76.32% // Head: 76.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
==========================================
+ Coverage 76.32% 76.71% +0.39%
==========================================
Files 4 4
Lines 697 713 +16
Branches 268 276 +8
==========================================
+ Hits 532 547 +15
- Misses 136 137 +1
Partials 29 29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's add tests cases so we will see do we have problem or not on windows
@alexander-akait I don't know how to test it. Without this RP everything works fine, except #370 |
@alexander-akait I've added some simple tests for |
Thank you I will wait answer #370 for a while, if there's no response by the end of the week, I'll make a release |
This PR contains a:
Motivation / Use-Case
isAbsolute
is not relevant then we use it the second time, because the first time we are testingresourcePath
and converting the filename to a relative path. We need to test it again before using it a second time.isAbsoluteURL
does not test Windows paths correctly.path.parse
andpath.join
are platform dependent.