-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-sass threadpool issue seems to still be there #147
Comments
Mhmm the latest should be fine. Can anyone confirm this? |
I think I've been able to reproduce it on this branch. https://github.com/adjavaherian/sass-lifter-loader/tree/node-sass-threadpool-issue If you npm start the branch in the current state, the process ties up and just hangs, but if you go to index.js and change the threadpool size to 4, It's tricky and very well could be a something to do with the way I'm creating new webpack instances from within a webpack loader. |
It seems you're running webpack from within webpack. Probably some part of that causes yet another node fs-thread to block. Maybe the maximum parallellism of sass-loader should be configurable, so you can set it at |
So I had to do Is that the permanent fix? Still feels more like a workaround. |
@jcreamer898 you should not need to adjust |
Ok, I'll update to the latest and see if I can run it now without it. Thanks! |
Anyone still having problems? |
Could you guys check if the branch |
Yeah, I'll have a look. |
@jhnns I still saw the issue in that branch unfortunately. The build I'm dealing with is quite large, so I'm not surprised. It hung at ~68% for me and just got stuck. |
Ha, I realized in my package.json I was on 2.0.1. Bumped to 3.1.1, removed the |
That's nice 👍 Could anyone reading this issue also check out the branch? I would like to pull it on the master, but I don't have a test setup that demonstrates the problem. |
I dont seem to have this problem anymore and I'm pretty sure we're using the master branch, so not sure what happened exactly. Hopefully this doesnt cause more confusion. :) Lemme double check in a bit. Sent from my iPony
|
Ya, I've been using 2.0.1 for a while now and not had any issues with threadpool. In fact, I don't even set the UV_THREADPOOL anymore and it seems to just work. I just tried npm installing the fix branch and it looks like there's a problem with its package.json? //package.json
"sass-loader": "git://github.com/jtangelder/sass-loader#fix/threadpool-issue", npm ls sass-loader
web@0.0.0 /home/adjavaherian/Desktop/web-off-master
└── sass-loader@3.1.0 invalid (git://github.com/jtangelder/sass-loader.git#d415f3fe1c8ad5e4c507fefa9f3734b4766d9d8f) |
Yep, I've messed up this release by forgetting to move Thx for trying it out 👍 |
I tried again with object-assign in my node_modules and noticed that my client config (which uses sass-loader) didn't even build. no errors, but no output either. hmm. |
I am having this same problem. Any progress on this? |
@bensampaio @adjavaherian Is there a problem so far? |
I just tried to remove |
@bensampaio where your can have |
this is resolved in v2.x and higher, right? |
@adjavaherian now |
Closing due to inactivity. Please test with latest version and feel free to reopen if still regressions. Thanks! |
I'm experiencing this right now with |
I'm also experiencing this with latest versions of node-sass and sass-loader, also working around by setting threadpool to 100 |
Experience this issue in @evilebottnawi Can we reopen? The above workaround feels like a hack. |
@casimcdaniels can you create minimum reproducible test repo and describe what is problem? |
The issue is still there, I guess, since sass/node-sass#857 hasn't been closed. |
I'm reopening this since it's still an issue for us |
@jhnns any ideas ho we can fix it? |
/cc @bensampaio can you provide minimum reproducible test repo there you have problem. Also if somebody have problem, feel free to feedback and try to provide minimum reproducible test repo, thanks |
Closing due to inactivity. Please test with latest version and feel free to reopen if still regressions. Thanks! |
I've just pulled @latest from sass-loader and node-sass, and I'm still seeing the processor peg at 100% as noted in #100 . Should I be using a different branch as a workaround? Thanks.
The text was updated successfully, but these errors were encountered: