Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolution algorithm for node-sass #866

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #863

Breaking Changes

No

Additional Info

Inside the comment in the source code

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #866 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #866      +/-   ##
==========================================
+ Coverage   97.91%   97.94%   +0.03%     
==========================================
  Files           4        4              
  Lines         192      195       +3     
  Branches       64       65       +1     
==========================================
+ Hits          188      191       +3     
  Misses          4        4              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/utils.js 97.43% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eabf500...a29ffb1. Read the comment docs.

@alexander-akait alexander-akait merged commit 4584c90 into master Jul 7, 2020
@alexander-akait alexander-akait deleted the issue-863 branch July 7, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in path resolution introduced in v9.0.x (import loop detected where there is no loop)
1 participant