Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] feat: removed cjs wrapper #281

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

ricardogobbosouza
Copy link
Collaborator

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

removed cjs wrapper and generated types in commonjs format (export = and namespaces used in types), now you can directly use exported types

Breaking Changes

Potentially yes, but now we use invalid format our types

Additional Info

No

@ricardogobbosouza ricardogobbosouza changed the title feat: removed cjs wrapper [2.x] feat: removed cjs wrapper May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #281 (22e6628) into 2.x (9e14831) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               2.x      #281   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         7    -1     
  Lines          223       249   +26     
  Branches        53        54    +1     
=========================================
+ Hits           223       249   +26     
Impacted Files Coverage Δ
src/StylelintError.js 100.00% <100.00%> (ø)
src/getStylelint.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/linter.js 100.00% <100.00%> (ø)
src/options.js 100.00% <100.00%> (ø)
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e14831...22e6628. Read the comment docs.

@ricardogobbosouza
Copy link
Collaborator Author

@alexander-akait probably last improvement in 2x, now it's just security fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants