Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path ignored #312

Merged
merged 5 commits into from
Jan 19, 2023
Merged

fix: path ignored #312

merged 5 commits into from
Jan 19, 2023

Conversation

ricardogobbosouza
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza commented Dec 30, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

The stylelint changed the internal API.
The creation of the linter is no longer exposed and with that the function isPathIgnored became unavailable

Breaking Changes

No

Additional Info

stylelint/stylelint#6415 (comment)

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4a56a3b) compared to base (f73c4ba).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          251       256    +5     
  Branches        50        50           
=========================================
+ Hits           251       256    +5     
Impacted Files Coverage Δ
src/getStylelint.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/linter.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ricardogobbosouza ricardogobbosouza merged commit 805b54c into master Jan 19, 2023
@ricardogobbosouza ricardogobbosouza deleted the fix-path-ignored branch January 19, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants