Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to upgrade to the latest AJV to fix punycode deprecation warning? #191

Open
dominic-p opened this issue Sep 25, 2024 · 8 comments

Comments

@dominic-p
Copy link

Feature Proposal

I'm getting deprecation warnings like this when I run webpack:

(node:23924) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.

It seems like these are caused by a deep dependency of an older ajv module. The most recent ajv (8.17.1) seems to fix this, so I'm wondering if we can update to silence the warnings.

npm ls punycode
my-project
└─┬ [email protected]
  └─┬ [email protected]
    └─┬ [email protected]
      └─┬ [email protected]
        └── [email protected]

Feature Use Case

It will just make the console output cleaner and less distracting.

Please paste the results of npx webpack-cli info here, and mention other relevant information

NA

@alexander-akait
Copy link
Member

@dominic-p
Copy link
Author

I can't believe I forgot to check before I opened this issue. Sorry about that. I guess the only thing we need now is to get webpack on the latest version of schema-utils and this will be resolved. I'll (check first and then) open an issue there.

Sorry for the noise.

@alexander-akait
Copy link
Member

@dominic-p
Copy link
Author

Ah, I see. Would it be possible to backport the ajv update to the 3.x branch of schema-utils? That way webpack could upgrade without requiring node 12+.

@alexander-akait
Copy link
Member

No, because ajv@8 and ajv@9 contain critical changes https://github.com/webpack/schema-utils/releases/tag/v4.0.0 and https://github.com/ajv-validator/ajv/releases/tag/v8.0.0, esecial

Option strict controls all strict mode restrictions

webpack itself does not have these problems and it is not difficult to migrate, the problem is in unofficial loaders that can stop working

@alexander-akait
Copy link
Member

Technically we can try to handle this and just display a warning, but all this will require quite a lot of work, we can start this by chaning the node version here to 10 and run it on CI to see if everything works

@dominic-p
Copy link
Author

Thanks for the feedback. I'm not familiar with the codebase at all, but I do know JS, so if you point me in the right direction, I can try to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants