Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack examples #378

Closed
Legends opened this issue Apr 7, 2018 · 5 comments
Closed

Webpack examples #378

Legends opened this issue Apr 7, 2018 · 5 comments

Comments

@Legends
Copy link
Member

Legends commented Apr 7, 2018

Do you want to request a feature or report a bug?
bug

What is the current behavior?

  • missing module: uri-js
  • Argument: mode, Given: "none", Choices: "development", "production"

If the current behavior is a bug, please provide the steps to reproduce.

In order to run the webpack examples I need to link webpack-cli.

git clone ..webpack-cli
yarn install
yarn link
cd local/webpack/repo
yarn link webpack-cli
yarn build:examples  --> missing module `uri-js`

webpack-cli repo^
Have to install uri-js to make it work.
yarn add uri-js --dev

webpack-repo
yarn build:examples
Build runs and fails at example source-maps:
--> Argument: mode, Given: "none", Choices: "development", "production"

Referencing existing/merged PR

What is the expected behavior?
Run the examples without any error.

Please paste the results of webpack-cli info here, and mention other relevant information such as programming language.
webpack-cli 2.0.14
webpack "4.5.0",
Win10 x64^

 System:
    OS: Windows 10
    CPU: x64 Intel(R) Core(TM) i7-3630QM CPU @ 2.40GHz
  Binaries:
    Node: 8.10.0
    Yarn: 1.5.1
    npm: 5.8.0
  Browsers: {}
  npmPackages:
    i18n-webpack-plugin:
      wanted: ^1.0.0
      installed: 1.0.0
    uglifyjs-webpack-plugin:
      wanted: ^1.2.4
      installed: 1.2.4
    webpack-dev-middleware:
      wanted: ^1.9.0
      installed: 1.12.2
    webpack-sources:
      wanted: ^1.0.1
      installed: 1.1.0
  npmGlobalPackages:
    webpack-cli: 2.0.14
@Legends
Copy link
Member Author

Legends commented Apr 8, 2018

@ematipico @sokra
This PR from sokra was merged, but is not part of master anymore?

Is it possible to remerge it? If not I can re-apply sokras PR

@Legends
Copy link
Member Author

Legends commented Apr 8, 2018

Btw. code-splitted-css-bundle example is empty, means only a readme.md exists...

@ematipico
Copy link
Contributor

ematipico commented Apr 8, 2018

We must have had some problems with other PR. You can make a PR to restore it if you can

@Legends
Copy link
Member Author

Legends commented Apr 8, 2018

It's a little effort to merge it back again, but it would be good to know why it was deleted... any open issue?
Because merging it again and then deleting it again would make no sense ;-)

@ematipico
Copy link
Contributor

Looking at the history of the file, it looks like we lost that commit. I am going to restore it and make a PR from that branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants