-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bundle analyzer #4141
base: master
Are you sure you want to change the base?
feat: Bundle analyzer #4141
Conversation
To add a boilerplate
reverted to orignal state
undone uneccesssary changes
…ck-cli into bundle-analyzer merger
cli-flags.js
Outdated
@@ -0,0 +1,159 @@ | |||
"use strict"; | |||
|
|||
module.exports = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? What problem does it solve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the file is made to privde the flags for the bundle analyzer plugin, had kept it in the root directory for now. Will move it to appropriate place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know if somethings wrong, or how to proceed further.
simpleType: "boolean", | ||
multiple: false, | ||
}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please send it to https://github.com/webpack-contrib/webpack-bundle-analyzer, this PR should be done in webpack-bundle-analyzer
repo and here we just will read it from require("webpack-bundle-analyzer").cli.arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@info-arnav could you do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure on it
created a cli flags file, please review. if correct ill move forward to complete it.
@snitin315 @alexander-akait
#1838