-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: autocomplete (rebase) #4327
base: master
Are you sure you want to change the base?
Conversation
chore(deps-dev): bump webpack-dev-server from 5.0.2 to 5.0.3 (webpack#4108)
Here is the rebase version an existing pull request I had made regarding autocomplete feature as said by sir @evenstensberg. Had to close the previous pr. I would love to take on this issue again if possible. Best. |
There's still conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super. We're going to review this pr multiple times. When we suggest a change, do the change and then we iterate.
Thanks for your contribution! <3
@@ -0,0 +1,152 @@ | |||
import * as Fs from "fs"; | |||
|
|||
// eslint-disable-next-line @typescript-eslint/no-var-requires |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be removed
I think there is some work still pending, one important thing is to find a way to fetch list of all the commands supported by webpack-cli to display on auto complete. I'm ready to take on this issue once again but this issue still I can't figure out how to fix. |
Could you create a todo in the pr description so we can see what you think is missing? |
What kind of change does this PR introduce?
feature #1402
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information