fix(Server): correct node version checks
#1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare two parsed node version in number form may cause unexpected behavior when they have the same major version and different special minor version, like 8.12 is greater than 8.6 in semantic version form, in contrast to the number form.
nekolab
requested review from
alexander-akait and
michael-ciniawsky
as code owners
alexander-akait
approved these changes
Oct 24, 2018
michael-ciniawsky
changed the title
node version checks
6 tasks
odinho
added a commit
to odinho/webpack-dev-server
that referenced
this pull request
Nov 8, 2018
This reverts commit 927a2b3. This is only a test to see whether it fixes Travis.
This was referenced Mar 7, 2021
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pull request #1531 we add a workaround for ECDH curve choice from node@^8.6.0 to node@10. We use parsed number to compare the version but it won't work as expected when compare like 8.12 to 8.6.
To fix this use version compare library is the best choice, since
semverhas been introduced into dependency tree bychokidar, choose it will not add package size.