Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regression): problem with idb-connector after update internal-ip #1691

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No need

Motivation / Use-Case

fixes #1689 fixes #1690

Breaking Changes

No

Additional Info

Update other deps too

/cc @arthureggert , i done other PR with updating other deps too, anyway thanks for PR and helping to us do webpack-dev-server better

@arthureggert
Copy link

@evilebottnawi Thanks, if approved when will we have a new version on npm!?

@alexander-akait
Copy link
Member Author

alexander-akait commented Feb 25, 2019

@arthureggert yep, after merge we release patch version

@arthureggert
Copy link

Thanks, I will close #1690 then.

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #1691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1691   +/-   ##
=======================================
  Coverage   84.39%   84.39%           
=======================================
  Files           7        7           
  Lines         519      519           
  Branches      159      159           
=======================================
  Hits          438      438           
  Misses         64       64           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b2076c...a43c4d8. Read the comment docs.

@alexander-akait alexander-akait merged commit eb48691 into master Feb 25, 2019
@alexander-akait alexander-akait deleted the issue-1689 branch February 25, 2019 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with idb-connector
2 participants