-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade webpack-cli to v3.3x #1754
Upgrade webpack-cli to v3.3x #1754
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1754 +/- ##
=======================================
Coverage 86.85% 86.85%
=======================================
Files 9 9
Lines 578 578
Branches 170 170
=======================================
Hits 502 502
Misses 63 63
Partials 13 13 Continue to review full report at Codecov.
|
package.json
Outdated
"webpack": "^4.29.0", | ||
"webpack-cli": "^3.2.1", | ||
"webpack": "^4.29.6", | ||
"webpack-cli": "github:webpack/webpack-cli#master", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is break webpack when developers don't have git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need check version if less < 3.2
use old logic, if >= 3.3
use new logic otherwise it was big breaking change
@evenstensberg can we don't change location right now? Or just create file with import/export, it is really looks like breaking change and in theory can break not only webpack-dev-server |
@evilebottnawi I got the idea to check if the new module with the new path exists or not and if it doesn't exist fall back to the original path so it can work with all versions v3.3.x and v3.2.x but I got that |
@EslamHiko just add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thanks!
@evilebottnawi you're Welcome 😄 |
For Bugs and Features; did you add new tests?
NO
Motivation / Use-Case
make webpack-dev-server work with webpack-cli v3.3.x
fixes #1753
Breaking Changes
Changed the paths of convert-argv & config-yargs
Additional Info
NO