feat(server): add callback support for invalidate #1900
Conversation
EslamHiko
force-pushed
the
add-callback-for-invalidate
branch
from
ebc9970
to
8d58882
Compare
EslamHiko
force-pushed
the
add-callback-for-invalidate
branch
from
8d58882
to
86871e1
Compare
test/Server.test.js
Outdated
| @@ -74,6 +75,51 @@ describe('Server', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Testing callback functions on calling invalidate without callback', () => { | |||
| it('should be `noop` (the default callback function)', () => { | |||
There was a problem hiding this comment.
Please use done because Server.test.js has already used done and can reduce code length.
After all, resolve is called in server.close in the callback, so you don't have to make a Promise.
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
==========================================
+ Coverage 91.13% 91.49% +0.35%
==========================================
Files 18 18
Lines 835 835
Branches 262 262
==========================================
+ Hits 761 764 +3
+ Misses 70 68 -2
+ Partials 4 3 -1
Continue to review full report at Codecov.
|
|
/cc @hiroppy |
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
==========================================
+ Coverage 91.13% 91.49% +0.35%
==========================================
Files 18 18
Lines 835 835
Branches 262 262
==========================================
+ Hits 761 764 +3
+ Misses 70 68 -2
+ Partials 4 3 -1
Continue to review full report at Codecov.
|
|
Thanks, good job! |
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
add tests for this PR : #1590
Breaking Changes
no
Additional Info