-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add WEBPACK_DEV_SERVER env variable #1929
Conversation
4e46438
to
7ee869e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1929 +/- ##
==========================================
+ Coverage 87.96% 87.99% +0.02%
==========================================
Files 15 15
Lines 814 816 +2
Branches 259 260 +1
==========================================
+ Hits 716 718 +2
Misses 84 84
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super neat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
fixes #1533
fixes #1532
Breaking Changes
No
Additional Info
No