Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onListening option #1930

Merged
merged 2 commits into from
May 29, 2019
Merged

feat: onListening option #1930

merged 2 commits into from
May 29, 2019

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

fixes #1569

Breaking Changes

No

Additional Info

  • Also added deprecation for next major release
  • This option allow to developers run own scripts after run webpack-dev-server

@alexander-akait alexander-akait requested a review from hiroppy as a code owner May 28, 2019 13:08
@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #1930 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1930      +/-   ##
==========================================
+ Coverage      88%   88.03%   +0.02%     
==========================================
  Files          16       16              
  Lines         817      819       +2     
  Branches      260      261       +1     
==========================================
+ Hits          719      721       +2     
  Misses         84       84              
  Partials       14       14
Impacted Files Coverage Δ
lib/Server.js 86.02% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87cfaa7...8bdbee8. Read the comment docs.

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #1930 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1930      +/-   ##
==========================================
+ Coverage   91.11%   91.13%   +0.02%     
==========================================
  Files          18       18              
  Lines         833      835       +2     
  Branches      261      262       +1     
==========================================
+ Hits          759      761       +2     
  Misses         70       70              
  Partials        4        4
Impacted Files Coverage Δ
lib/Server.js 91.55% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9297988...2466438. Read the comment docs.

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait
Copy link
Member Author

/cc @hiroppy done

@hiroppy hiroppy merged commit 61d0cdf into master May 29, 2019
@hiroppy
Copy link
Member

hiroppy commented May 29, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listeningApp is defined late and cannot be used in before/after functions
2 participants