fix(server): Change clientLogLevel order to be called first #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested changes
Jun 5, 2019
lib/Server.js
Outdated
| if (this.hot) { | ||
| this.sockWrite([connection], 'hot'); | ||
| } | ||
|
|
||
| if (this.options.liveReload !== false) { | ||
| if (this.options.liveReload) { |
There was a problem hiding this comment.
Can be breaking change for non boolean value, let's avoid this in this PR
There was a problem hiding this comment.
ok, I'll change it at next major version.
hiroppy
force-pushed
the
feature/fix-client-log
branch
from
239150a
to
fcf85c2
Compare
|
Sorry, I contained another commit to put .gitkeep. |
alexander-akait
approved these changes
Jun 5, 2019
wizardofhogwarts
approved these changes
Jun 5, 2019
This was referenced Dec 14, 2019
This was referenced Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
maybe related #1972.
before
after
Breaking Changes
no
Additional Info