fix(server): check for external urls in array #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1980 +/- ##
==========================================
- Coverage 92.8% 92.73% -0.08%
==========================================
Files 31 31
Lines 1181 1183 +2
Branches 329 328 -1
==========================================
+ Hits 1096 1097 +1
- Misses 81 82 +1
Partials 4 4
Continue to review full report at Codecov.
|
alexander-akait
requested changes
Jun 6, 2019
test/ExternalPathsWatch.test.js
Outdated
| @@ -0,0 +1,91 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
test/ExternalPathsWatch.test.js
Outdated
| }); | ||
|
|
||
| describe('testing single & multiple internal paths', () => { | ||
| it('Should not throw exception (single line)', (done) => { |
EslamHiko
commented
Jun 6, 2019
test/ContentBase.test.js
Outdated
| testServer.close(() => { | ||
| done(); | ||
| }); | ||
| done(); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| describe('testing single & multiple internal paths', () => { |
There was a problem hiding this comment.
tests in this part are not necessary, all other tests already test with valid contentBase.
EslamHiko
force-pushed
the
handle-array-paths
branch
from
4e1ab38 to
6fccea4
Compare
|
@evilebottnawi since we have now |
|
@EslamHiko yes, will be great 👍 |
|
Sorry for delay |
hiroppy
approved these changes
Jul 1, 2019
|
Thanks! |
|
@evilebottnawi no problems 😃. @hiroppy My pleasure 😄. |
knagaitsev
pushed a commit
to knagaitsev/webpack-dev-server
that referenced
this pull request
Jul 31, 2019
* fix: check for external urls in array * test: move tests to contentBase * fix: use is-absolute-url & add test case for number type
2 tasks
This was referenced Dec 14, 2019
This was referenced Feb 22, 2020
This was referenced Mar 14, 2020
This was referenced May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
fixes : #1879
Breaking Changes
no
Additional Info
Tests pass then errors show up 😕 maybe because I use windows, let's see will CI be green or not.