-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: es6 syntax in client #1982
Conversation
Test structure (approximately):
Test naming:
Next we should improve test performance, many tests are very long and written in effective way. Some of tests files should be merge in other, some of separated based on above structure. I am WIP on this after merge this PR |
@@ -4,7 +4,7 @@ const testServer = require('../helpers/test-server'); | |||
const config = require('../fixtures/provide-plugin-config/webpack.config'); | |||
const runBrowser = require('../helpers/run-browser'); | |||
|
|||
describe('ProvidePlugin', () => { | |||
describe.skip('ProvidePlugin', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need rewrite tests
Codecov Report
@@ Coverage Diff @@
## master #1982 +/- ##
=========================================
- Coverage 92.47% 92.27% -0.2%
=========================================
Files 28 28
Lines 1076 1075 -1
Branches 322 322
=========================================
- Hits 995 992 -3
- Misses 77 79 +2
Partials 4 4
Continue to review full report at Codecov.
|
Merge without review because it is critical, feel free to feedback |
I would like to separate utils tests. Utils shouldn't have to test through the server. It is e2e. |
@hiroppy yes, utils should have own unit tests and in |
For Bugs and Features; did you add new tests?
no, it is critical fix, test will be in future
Motivation / Use-Case
fixes #1981
Breaking Changes
No
Additional Info
/cc @hiroppy @Loonride I am temporary block merge any PRs before we refactor tests/tests strcuture/structure inside lib (for any branches)
Please don't touch next branch before we do this in master